From ca366edbb650c00ef5257d02bee5de9e5ef3df91 Mon Sep 17 00:00:00 2001 From: Niels Kooiman Date: Thu, 14 Mar 2019 21:01:44 +0100 Subject: [PATCH] camelcase --- package.json | 3 ++- src/domain/domain.ts | 2 +- src/domain/services/MusicCatalogService.spec.ts | 2 +- src/index.ts | 5 +++-- src/view/MusicComponent.spec.ts | 2 +- src/view/MusicComponent.ts | 4 ++-- 6 files changed, 10 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 2d548db..64f700d 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,8 @@ "types": "dist/index.d.ts", "scripts": { "pkg-update": "node pkg-update", - "build": "tsc --listEmittedFiles", + "build": "tsc", + "_build": "tsc --listEmittedFiles", "test": "jasmine-ts --config=jasmine.json" }, "repository": { diff --git a/src/domain/domain.ts b/src/domain/domain.ts index 71cbbcc..183c959 100644 --- a/src/domain/domain.ts +++ b/src/domain/domain.ts @@ -12,7 +12,7 @@ class Domain this.portResolver = portResolver; } - get MusicCatalog() { return this.resolve('IMusicCatalog'); } + public get musicCatalog() { return this.resolve('IMusicCatalog'); } } const domain = new Domain(); export default domain; \ No newline at end of file diff --git a/src/domain/services/MusicCatalogService.spec.ts b/src/domain/services/MusicCatalogService.spec.ts index d8c6868..2bfc2b7 100644 --- a/src/domain/services/MusicCatalogService.spec.ts +++ b/src/domain/services/MusicCatalogService.spec.ts @@ -15,7 +15,7 @@ describe("MusicCatalog", () => { let spiedGet = spyOn(fakeMusicRepository, 'get').and.returnValue([]); resolver.registerInstance('IMusicRepository', () => fakeMusicRepository); resolver.registerInstance('IMusicCatalog', () => new MusicCatalogService()); - domain.MusicCatalog.get(); + domain.musicCatalog.get(); expect(spiedGet.calls.count()).toBe(1); diff --git a/src/index.ts b/src/index.ts index 4c1883d..6275379 100644 --- a/src/index.ts +++ b/src/index.ts @@ -1,7 +1,8 @@ import './wiring/Wiring'; -import { MusicCatalogService } from './domain/services/MusicCatalogService'; import { Track } from './domain/models/Track'; +import domain from './domain/domain'; +const musicCatalog = domain.musicCatalog; -export { MusicCatalogService, Track }; +export { musicCatalog, Track }; // MusicRepository diff --git a/src/view/MusicComponent.spec.ts b/src/view/MusicComponent.spec.ts index 65dd0f3..a7cef37 100644 --- a/src/view/MusicComponent.spec.ts +++ b/src/view/MusicComponent.spec.ts @@ -18,7 +18,7 @@ describe("MusicComponent", () => { //let spiedAdd = spyOn(fakeMusicRepository, 'add').and.returnValue([]); resolver.registerInstance('IMusicRepository', () => fakeMusicRepository); resolver.registerInstance('IMusicCatalog', () => new MusicCatalogService()); - expect(domain.MusicCatalog).not.toBe(null); + expect(domain.musicCatalog).not.toBe(null); let musicComponent = new MusicComponent(); expect(musicComponent).not.toBe(null); diff --git a/src/view/MusicComponent.ts b/src/view/MusicComponent.ts index d432095..f52638c 100644 --- a/src/view/MusicComponent.ts +++ b/src/view/MusicComponent.ts @@ -5,7 +5,7 @@ import { Track } from "../domain/models/Track"; export class MusicComponent { constructor() { let track = new Track(8, "Niels 1st", "Niels Kooiman", 45); - domain.MusicCatalog.add(track); - let tracks = domain.MusicCatalog.get(); + domain.musicCatalog.add(track); + let tracks = domain.musicCatalog.get(); } }